Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- change ICU_LINK configuration #70

Closed
wants to merge 2 commits into from

Conversation

SSE4
Copy link
Contributor

@SSE4 SSE4 commented Oct 6, 2021

closes: #55

this is basically a port of the following boost.regex commit: boostorg/regex@fc4dc17

summary:

  • ICU_LINK is deprecated
  • added more granular variables to control ICU library names (ICU_ICUUC_NAME, ICU_ICUDT_NAME, ICU_ICUIN_NAME)
  • static ICU is allowed (it's already allowed in regex, no reason to forbid it)

/cc @grafikrobot

Signed-off-by: SSE4 <tomskside@gmail.com>
@artyom-beilis
Copy link
Member

Are you sure about it: https://github.com/boostorg/locale/pull/70/files#diff-54876b48ff1d36d4e9f8ff25a1cb2c9ff33db706dc6eb8b82ca63ae2953daf2dL19

- #error "Mixing ICU with a static runtime doesn't work"
+// #error "Mixing ICU with a static runtime doesn't work"

Unlike regex it needs icudata with all locale information. I recall some issues with it. That without dll it does not have relevant data.

Have you tested it?

Also can somebody help me reviewing the b2 files. I really barely understand them

build/Jamfile.v2 Outdated
Comment on lines 119 to 127
if $(ICU_ICUDT_NAME)
{
lib icudt : : <name>$(ICU_ICUDT_NAME) ;
}
else
{
searched-lib icudt : : <search>$(ICU_PATH)/lib
<name>icudata
<link>shared
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be consistent should use either lib or search-lib targets. The regex build uses lib consistently.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, I'll try to change that

@SSE4
Copy link
Contributor Author

SSE4 commented Oct 6, 2021

Have you tested it?

I've just run some tests for shared and static ICU builds, both failed...

test_shared.log
test_static.log

I can try to fix them, but only with some guidance, I am not very familiar with boost locale

Signed-off-by: SSE4 <tomskside@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICU_LINK option does not work anymore
3 participants