Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconfiguring with BUILD_TESTING=OFF doesn't disable tests #97

Closed
pdimov opened this issue Dec 17, 2023 · 1 comment
Closed

Reconfiguring with BUILD_TESTING=OFF doesn't disable tests #97

pdimov opened this issue Dec 17, 2023 · 1 comment

Comments

@pdimov
Copy link
Member

pdimov commented Dec 17, 2023

When Lockfree is configured with cmake -DBUILD_TESTING=ON .., and then reconfigured with cmake -DBUILD_TESTING=OFF ., tests remain enabled. That's because BUILD_TESTING is only used once as the default value of BOOST_LOCKFREE_BUILD_TESTS and is ignored afterwards.

That's not how all other Boost libraries work; they check BUILD_TESTING directly and do not add_subdirectory(test) if it's off.
@timblechmann
Copy link
Collaborator

#96 should fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@timblechmann @pdimov