Skip to content

Commit

Permalink
Removed use of unit_test_framework namespace as is obselete. BOOST_TE…
Browse files Browse the repository at this point in the history 
…ST_MESSAGE should be enabled by adding --log_level=message to run parameters if required
  • Loading branch information
@pabristow
pabristow committed Nov 4, 2019
1 parent cff7b64 commit 1d04bf7
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions test/test_lambert_w.cpp
View file
Expand Up @@ -24,6 +24,9 @@
// Boost macros
#define BOOST_TEST_MAIN
#define BOOST_LIB_DIAGNOSTIC "on" // Report library file details.
//#define BOOST_TEST_LOG_LEVEL all // Appears not to work???
// run with --log_level="message"

#include <boost/test/included/unit_test.hpp> // Boost.Test
// #include <boost/test/unit_test.hpp> // Boost.Test
#include <boost/test/tools/floating_point_comparison.hpp>
Expand Down Expand Up @@ -801,8 +804,9 @@ BOOST_AUTO_TEST_CASE( test_types )
BOOST_MATH_CONTROL_FP;
// BOOST_TEST_MESSAGE output only appears if command line has --log_level="message"
// or call set_threshold_level function:
boost::unit_test_framework::unit_test_log.set_threshold_level(boost::unit_test_framework::log_messages);
BOOST_TEST_MESSAGE("\nTest Lambert W function for several types.");
// boost::unit_test::unit_test_log.set_threshold_level(boost::unit_test_framework::log_messages);

BOOST_TEST_MESSAGE("\nTest Lambert W function for several types.\n");
BOOST_TEST_MESSAGE(show_versions()); // Full version of Boost, STL and compiler info.
#ifndef BOOST_MATH_TEST_MULTIPRECISION
// Fundamental built-in types:
Expand Down

6 comments on commit 1d04bf7

@jzmaddock
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Paul: I've messaged the mailing list about this as one other library (Fiber) is also effected.
You could also have just changed "unit_test_framework" to "unit_test" and everything would have built OK - I was just testing that when you beat me to it :)

@pabristow
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I did figure that unit_test_framework was renamed, but it seemed that the extra messages are only useful for a developer and just clutter the testers disks, so leaving it optional was actually the better fix. Seems to have passed on one tester, but the lambert_w_multiprecision tests have yet to cycle, so I'll wait for these before I close the issue..

@NAThompson
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this needs to go into master before release?

@pabristow
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you we not missed the deadline for this release? It only affects anyone actually running the math tests, a minority sport?

@NAThompson
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.72 is open for bug fixes until next week, so I think it will be good to make this change; otherwise the regression testers are gonna find it.

@pabristow
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that Raffi is dealing with this by reverting the change of namespace name, so there is no need to get this change into this release.

Please sign in to comment.