Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue 675 #676

Merged
merged 1 commit into from
Aug 23, 2021
Merged

Fix for issue 675 #676

merged 1 commit into from
Aug 23, 2021

Conversation

mborland
Copy link
Member

Fixes for #675. Allows for switching of BOOST_MATH_HEADER_DEPRECATED based on standalone context. Fixes behavior of standalone implementation.

@NAThompson
Copy link
Collaborator

Ready to go?

@mborland
Copy link
Member Author

Ready to go?

Yes; this is good.

@NAThompson NAThompson merged commit 720536a into boostorg:develop Aug 23, 2021
@jzmaddock
Copy link
Collaborator

Merging. Do we need to run the new test in standalone mode as well?

@thesamesam
Copy link

Thanks both. This indeed resolves the issue downstream for us in Gentoo. Cheers for the quick fix!

@NAThompson
Copy link
Collaborator

@jzmaddock : I want to do a new standalone release upon resolution of #677 ; do we have a good CI solution for testing our standalone releases?

@mborland mborland deleted the issue675 branch August 23, 2021 17:58
@jzmaddock
Copy link
Collaborator

We would need to merge to master, and then just check that the CI run on master is clean.

@mborland
Copy link
Member Author

@jzmaddock : I want to do a new standalone release upon resolution of #677 ; do we have a good CI solution for testing our standalone releases?

None of the current tests in the CI battery define BOOST_MATH_STANDALONE. I can open a PR for a new YAML file that runs against a different branch say standalone_master. That way you could just run it periodically instead of every time something is committed to develop. Currently the only thing that is tested in standalone mode is the compile tests using CMake. Thoughts?

@NAThompson
Copy link
Collaborator

Our CI suite is already pretty expensive. Maybe one configuration on each merge request, and then a big run on master or standalone_master.

We should probably see how @jzmaddock feels about having the standalone a bit out of sync with the Boost release cadence.

@mborland mborland mentioned this pull request Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants