Workaround for bogus [-Wignored-attributes] warning on GCC 6.x/7.x #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Retested locally for several GCC and MSVC versions, looks fine. Many thanks for the patch! |
|
You're welcome! Thanks for re-testing and merging :) |
igaztanaga
added a commit
that referenced
this pull request
Nov 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've executed the Boost.Move and Boost.Container tests with GCC 6.3 & MSVC 2017 => pass.
I've also verified the general "technique" (wrapping the struct with the alignment attribute in another struct) with several GCC, ICC and Clang versions, and it seems to work fine - i.e. no bugs where the compiler "loses" the alignment for the wrapper struct or the wrapper struct comes out with an unexpected size.
So I guess this should be safe.