Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed angled brackets with quotes for gcc include file in preproces… #32

Merged
merged 1 commit into from Feb 26, 2018
Merged

Conversation

mihaipop11
Copy link

Fix to ticket #13449

@mclow
Copy link
Contributor

mclow commented Feb 15, 2018

I have no opinion on this specific change, but in general, headers in the boost/ hierarchy are included via angle-brackets. However, I've read the trac issue, so I see where you're coming from.

@mihaipop11
Copy link
Author

i can understand that a general guideline is nice to have for the sources, another fix for this would be to disable the GNU Extensions by compiling with -std=c++{98,11,14,17,2a} but this is not a generic solution

@mihaipop11
Copy link
Author

mihaipop11 commented Feb 15, 2018

i can see how you think that probably is not worth it just because someone tries to run the script in a folder named linux, normally i wouldn't care about this minor thing, but lets take this example: in a yocto project context it is a high change to have in the path a folder named linux and it's not that nice to fix it

@eldiener
Copy link
Contributor

Are you saying that the mnemonic 'linux' is a macro under gcc ?

@mclow
Copy link
Contributor

mclow commented Feb 26, 2018

Are you saying that the mnemonic 'linux' is a macro under gcc ?

Yes, that's what he's saying.
Along with a whole bunch of other names. :-(
Use gcc -dM -E - < /dev/null to show them all.
Fortunately most (but not all) of them start with a double underscore.

@mihaipop11
Copy link
Author

mihaipop11 commented Feb 26, 2018

indeed, before ANSI i believe, there was no standard regarding these macros so the developers just used linux, unix... , then when the ANSI standard was created, the developers reached the conclusion that the macros should start with double underscore and end with double underscore ex: __linux__

@eldiener
Copy link
Contributor

As long as this does not affect anything negatively I can merge this. Is there any case in which the switch from <> to "" might cause any problems in the gcc invocation with current versions of gcc ?

@mihaipop11
Copy link
Author

not that i know of. i tried with gcc5-6-7, in all cases there were no problems after the patch was applied.

@eldiener eldiener merged commit 29c10a7 into boostorg:develop Feb 26, 2018
@mihaipop11 mihaipop11 deleted the changes branch February 26, 2018 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants