Disable warnings from deprecated numeric_limits members. #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building with MSVC in C++23 mode.
mborland
reviewed
Dec 7, 2023
| static constexpr float_denorm_style has_denorm = denorm_absent; | ||
| #ifdef _MSC_VER | ||
| #pragma warning(pop) | ||
| #endif | ||
| static constexpr bool has_denorm_loss = false; |
There was a problem hiding this comment.
Do the instances of has_denorm_loss need to go in between the pragmas since it's deprecated as well?
There was a problem hiding this comment.
I don't believe so... it's a simple bool so no warning is generated, it's our use of float_denorm_style that was causing the issue I believe.
|
Single failure is a clone/network issue, merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building with MSVC in C++23 mode.
Fixes #573
Refs #574