-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Having ode conditionally depend on Boost::MPI (or allow standalone for cmake) #82
Comments
It wouldn't be truly standalone because the library has a ton of internal boost dependencies. Would removing all the adapters from |
I think From reading those comments it looks like odeint would have to be careful that boostdep does not re-add the For background, I'm moving Stan Math over to use cmake and I'd like to use boosts cmake scheme. We currently use odeint as a header only library from the release version of boost, which is fine and does not depend on the user having mpi. But using the cmake scheme does require mpi which is not super fun. I also fear many of our users just won't have that installed. I think just excluding the adaptors (and their dependencies)** would fix this though. Another fix would be to allow users to specify which adaptors they want and then make them in charge of including the dependencies for those **EDIT |
|
odeint's cmake currently requires
Boost::mpi
(see here) and I think a few other boost libraries that much be prebuilt before hand. I think mpi can be kind of a big requirement for a lot of users. It's possible for odeint to be included as a header only library if it is in standalone mode.Could you add a cmake flag to specify whether the other boost libraries should be included as dependencies? Something like
The text was updated successfully, but these errors were encountered: