Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C++20 breaks optional<std::filesystem::path> #78

Closed
CaseyCarter opened this issue Dec 19, 2019 · 1 comment · Fixed by #79
Closed

C++20 breaks optional<std::filesystem::path> #78

CaseyCarter opened this issue Dec 19, 2019 · 1 comment · Fixed by #79

Comments

@CaseyCarter
Copy link
Contributor

Per detailed discussion on Developer Community, determining if optional<std::filesystem::path> is copy assignable results in constraint recursion in C++20.

The fix is to avoid instantiating the is_constructible check in is_convertible_to_T_or_factory when the is_optional_related<U> check in is_optional_val_init_candidate yields true.
@CaseyCarter CaseyCarter mentioned this issue Dec 19, 2019
Merged
akrzemi1 added a commit that referenced this issue Dec 19, 2019
@akrzemi1
Add test case for fix to issue #78
13bc276
@akrzemi1
Copy link
Member

Thank you for the report and fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't instantiate is_convertible_to_T_or_factory when is_optional_rel… CaseyCarter/optional
2 participants
@CaseyCarter @akrzemi1