Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supressed 'unused parameters' warnings. #1

Closed
wants to merge 2 commits into from
Closed

Supressed 'unused parameters' warnings. #1

wants to merge 2 commits into from

Conversation

povilasb
Copy link

@povilasb povilasb commented Jun 8, 2014

No description provided.

@danieljames
Copy link
Contributor

I think this is already addressed in develop in:

b5e57e0

I want to merge it to master pretty soon.

@eldiener
Copy link
Collaborator

You should not be making PRs on the 'master' branch. If the fix is already in 'develop' it will get into 'master' when 'develop' is merged to 'master'.

@eldiener
Copy link
Collaborator

My error. I see where the 'develop' and the 'master' branch have not been synced for a long time so I understand why this PR was made.

@eldiener
Copy link
Collaborator

I manually merged the "suppress 'unused parameter' warning/error" portion of your PR. The removing of trailing white spaces is not necessary for correct C++ compilation.

@eldiener eldiener closed this Jul 19, 2015
@povilasb
Copy link
Author

Well trailing white space removal is for code neatness. They are totally redundant :)

eldiener pushed a commit that referenced this pull request Oct 19, 2018
Merge with boostorg/parameter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants