-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented BOOST_PFR_ENABLED macro #86
Merged
apolukhin
merged 10 commits into
boostorg:develop
from
denzor200:feature/85-boost_no_pfr_macro
Dec 18, 2022
Merged
Implemented BOOST_PFR_ENABLED macro #86
apolukhin
merged 10 commits into
boostorg:develop
from
denzor200:feature/85-boost_no_pfr_macro
Dec 18, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 954428715
💛 - Coveralls |
Pull Request Test Coverage Report for Build 3725964878
💛 - Coveralls |
I think this is a bad idea.. But we will not close it yet |
denzor200
commented
Dec 2, 2022
This idea may become good if we provide the way to override compiler's decision manually. Like this:
I'll continue working on it. |
denzor200
commented
Dec 10, 2022
…o_pfr_macro Conflicts: doc/pfr.qbk include/boost/pfr/detail/config.hpp test/print_config.cpp
apolukhin
requested changes
Dec 18, 2022
apolukhin
approved these changes
Dec 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New macro tested on the Godbolt in so many variants:
case 1 (before) : https://godbolt.org/z/hjhKf3h5n
case 1 (after) : https://godbolt.org/z/vfeKfcMh7
case 2 (before) : https://godbolt.org/z/bvfocY1v1
case 2 (after) : https://godbolt.org/z/bnYboGYa5
case 3 (before) : https://godbolt.org/z/es7cEoo75
case 3 (after) : https://godbolt.org/z/sMdr1vGPW