Fix C++20 incompatibility from using exception specifications #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pdimov Please, take a look. |
Lastique
force-pushed
the
feature/fix_cxx23_nothrow
branch
2 times, most recently
from
0617459
to
86e6f81
Compare
Lastique
changed the title
|
Actually, |
C++20 removed support for `throw()` exception specifications, so at least clang-19 is now emitting errors on them. Replaced exception specifications with BOOST_NOEXCEPT_OR_NOTHROW, which converts `throw()` to `noexcept`, but keeps the code formally compatible with C++03.
Lastique
force-pushed
the
feature/fix_cxx23_nothrow
branch
from
86e6f81
to
1d7ccef
Compare
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C++20 removed support for exception specifications, so at least clang-19 is now emitting errors on them. Replaced exception specifications with
BOOST_NOEXCEPT_OR_NOTHROW, which convertsthrow()tonoexcept, but keeps the code formally compatible with C++03.This has been brought up during Boost 1.85.0 release preparation.
This PR is similar to the following PRs, and once this one or one of those is merged, the others can be closed:
#118 - this PR is similar to that one, but resolves merge conflicts.
#129 - unlike that PR, this one does not remove exception specifications from destructors, which keeps the code formally compatible with C++03.
This PR also updates GitHub Actions config to fix CI failures on clang-13 through 15 due to their incompatibility with libstdc++-13 in C++23 mode. (The failures are unrelated to this PR.)