Remove algorithm dep #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove trailing whitespace from modified lines. git grep -l BOOST_STRING_TYPENAME | xargs sed -i 's|BOOST_STRING_TYPENAME *$|typename|' git grep -l BOOST_STRING_TYPENAME | xargs sed -i 's|BOOST_STRING_TYPENAME \(.*\) +$|typename \1|' git grep -l BOOST_STRING_TYPENAME | xargs sed -i 's|BOOST_STRING_TYPENAME|typename|' Remove include of header from Boost.Algorithm library providing the define.
Remove dependency on Boost.Algorithm library.
|
|
||
|
|
||
| typedef double yes_type; | ||
| typedef char no_type; |
There was a problem hiding this comment.
Why don't these replacement types have guaranteed different sizes?
There was a problem hiding this comment.
I think a conforming implementation can have sizeof(double) = 1. (I'm not aware of any implementations like this in practice.)
There was a problem hiding this comment.
I am not aware of them either, but it costs nothing to define these types as char (&)[1] and char (&)[2].
There was a problem hiding this comment.
I will change it if someone says it's a condition to merge it. Will either of you merge it, or will I still be waiting for someone else?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.