Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit Boost reviews and implement what is meaningful #53

Closed
mzimbres opened this issue Jan 28, 2023 · 2 comments
Closed

Revisit Boost reviews and implement what is meaningful #53

mzimbres opened this issue Jan 28, 2023 · 2 comments

Comments

@mzimbres
Copy link
Collaborator

mzimbres commented Jan 28, 2023

In addition to the conditions for acceptance other suggestions must be reviewed and implemented when possible/meaningful. Reviews can be found at: https://lists.boost.org/Archives/boost/2023/01/date.php

Links to individual reviews can be found below

  1. Zach Laine: https://lists.boost.org/Archives/boost/2023/01/253883.php
  2. Vinnie Falco: https://lists.boost.org/Archives/boost/2023/01/253886.php
  3. Christian Mazakas: https://lists.boost.org/Archives/boost/2023/01/253900.php
  4. Ruben Perez: https://lists.boost.org/Archives/boost/2023/01/253915.php
  5. Dmitry Arkhipov: https://lists.boost.org/Archives/boost/2023/01/253925.php
  6. Alan de Freitas: https://lists.boost.org/Archives/boost/2023/01/253927.php
  7. Mohammad Nejati: https://lists.boost.org/Archives/boost/2023/01/253929.php
  8. Sam Hartsfield: https://lists.boost.org/Archives/boost/2023/01/253931.php
  9. Miguel Portilla: https://lists.boost.org/Archives/boost/2023/01/253935.php
  10. Robert A.H. Leahy: https://lists.boost.org/Archives/boost/2023/01/253928.php

The thread with the ACCEPT from the review manager can be found here: https://lists.boost.org/Archives/boost/2023/01/253944.php.

@maxwellb
Copy link

Regarding the suggestion to offer enum values for command names in place of requiring strings, please continue to allow strings for command names. A configuration file may still rename commands, though it has been labeled "deprecated" since Redis 6.0.

@mzimbres
Copy link
Collaborator Author

Most code review requirements have been implemented by now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants