Missing #include in throw_exception.hpp #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boost/serialization/throw_exception.hpp does not include the header which defines boost::throw_exception leading to compiler errors unless that header just happens to be #included elsewhere. See this message thread: https://lists.boost.org/boost-users/2022/01/91144.php Likewise the std lib header <exception> is *not* required since we use nothing from that here.
uecasm
reviewed
Jan 12, 2022
| @@ -18,7 +18,7 @@ | |||
| #include <boost/config.hpp> | |||
|
|
|||
| #ifndef BOOST_NO_EXCEPTIONS | |||
There was a problem hiding this comment.
This needs to be an #ifdef, not an #ifndef. Or just include it unconditionally since it contains a similar check internally.
There was a problem hiding this comment.
You're right, but that still doesn't look right to me somehow :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
boost/serialization/throw_exception.hpp does not include the header which defines boost::throw_exception leading to compiler errors unless that header just happens to be #included elsewhere. See this message thread: https://lists.boost.org/boost-users/2022/01/91144.php
Likewise the std lib header is not required since we use nothing from that here.