Broken boost::sort::spreadsort::string_sort

[sgn]

Below function

sort/include/boost/sort/spreadsort/detail/string_sort.hpp

Lines 696 to 705 in db798f6

	template <class RandomAccessIter, class Unsigned_char_type>
	inline typename boost::disable_if_c< sizeof(Unsigned_char_type) <= 2, void
	>::type
	string_sort(RandomAccessIter first, RandomAccessIter last,
	Unsigned_char_type)
	{
	//Warning that we're using boost::sort::pdqsort, even though string_sort was called
	BOOST_STATIC_ASSERT( sizeof(Unsigned_char_type) <= 2 );
	boost::sort::pdqsort(first, last);
	}

Will be disable if sizeof(Unsigned_char_type) <= 2, that means that function will be enabled when sizeof(Unsigned_char_type) > 2.

However, when sizeof(Unsigned_char_type) > 2, the BOOST_STATIC_ASSERT( sizeof(Unsigned_char_type) <= 2 ); will run into failure.

[spreadsort]

Good point, I missed that in the code review for #40. I'll remove the unnecessary ASSERTs.

…

On Sat, Dec 17, 2022 at 2:30 AM Đoàn Trần Công Danh < ***@***.***> wrote: Below function https://github.com/boostorg/sort/blob/db798f62caea5b6e56c98a12daeaf336e4e78561/include/boost/sort/spreadsort/detail/string_sort.hpp#L696-L705 Will be disable if sizeof(Unsigned_char_type) <= 2, that means that function will be enabled when sizeof(Unsigned_char_type) > 2. However, when sizeof(Unsigned_char_type) > 2, the BOOST_STATIC_ASSERT( sizeof(Unsigned_char_type) <= 2 ); will run into failure. — Reply to this email directly, view it on GitHub <#66>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABG2HXFJYSON72YSFMQ7P73WNVTZDANCNFSM6AAAAAATBZYPVM> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[spreadsort]

Thanks for spotting that! The fix is in develop: 2e6674d

[spreadsort]

merge into master is here: #67, waiting on Francisco's review.