Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing tests in MSVC #503

Closed
djowel opened this issue May 2, 2019 · 3 comments
Closed

Fix failing tests in MSVC #503

djowel opened this issue May 2, 2019 · 3 comments
Assignees
@djowel

Comments

@djowel
Copy link
Member

djowel commented May 2, 2019

Those tests are failing on MSVC in our CI https://ci.appveyor.com/project/Kojoley/spirit-jod4k/builds/24112491/job/w1lcg5vgrw9mta32?fullLog=true
@djowel djowel self-assigned this May 2, 2019
djowel referenced this issue May 2, 2019
@djowel
Fix for #421
be7640b 
WIP: https://svn.boost.org/trac10/ticket/11608
@djowel
Copy link
Member Author

djowel commented May 4, 2019

Hmmm, I just tested with VS Studio 2017 and all tests pass just fine.

@djowel
Copy link
Member Author

djowel commented May 4, 2019

Let me see if I can get VS 2015

djowel added a commit that referenced this issue May 4, 2019
@djowel
Fix for #503. Float compariso is tricky. eps for comparision is wrong…
80bb2a9 
… in some cases.
@djowel
Copy link
Member Author

djowel commented May 4, 2019

OK, it should be address-model=64. Fixed.

@djowel djowel closed this as completed May 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@djowel djowel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@djowel