Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

X3: Fixed static assert on parse_rule instantiation #455

Merged
merged 1 commit into from Feb 8, 2019

Conversation

Projects
None yet
1 participant
@Kojoley
Copy link
Collaborator

commented Feb 7, 2019

During overload resolution disallowed signature can be instantiated leading to firing the static assertation and overload resolution failure. I could just remove it, but do not want to leave unbounded by value overloads; replacing to not deducing Attribute with specifying a default parameter will not work because we want to allow BOOST_SPIRIT_DECLARE without prior BOOST_SPIRIT_DEFINE - this requires having default parameters in both declaration and definition and the standard seems to forbid it (GCC - fine, MSVC - warning, Clang - error).

Reverts #437, fixes #453.

@Kojoley Kojoley force-pushed the Kojoley:x3-instantiate-static-assert branch 2 times, most recently from dec0c9c to 9982b00 Feb 7, 2019

X3: Fixed static assert on parse_rule instantiation
During overload resolution disallowed signature can be instantiated leading
to firing the static assertation and overload resolution failure. I could
just remove it, but do not want to leave unbounded by value overloads;
replacing to not deducing Attribute with specifying a default parameter will
not work because we want to allow `BOOST_SPIRIT_DECLARE` without prior
`BOOST_SPIRIT_DEFINE` - this requires having default parameters in both
declaration and definition and the standard seems to forbid it (GCC - fine,
MSVC - warning, Clang - error).

Reverts #437, fixes #453.

@Kojoley Kojoley force-pushed the Kojoley:x3-instantiate-static-assert branch from 9982b00 to 735b4ec Feb 7, 2019

@Kojoley Kojoley merged commit afe763b into boostorg:develop Feb 8, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Kojoley Kojoley deleted the Kojoley:x3-instantiate-static-assert branch Feb 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.