X3: Fix on_success dispatcher inverted iterator const/mutability
#711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of usual `[current, end)` pair it receives `[before, current)` pair.
Kojoley
force-pushed
the
x3-on_success-dispatcher-inverted-iterator-mutability
branch
from
f967d9a
to
facd2ee
Compare
Kojoley
deleted the
x3-on_success-dispatcher-inverted-iterator-mutability
branch
jktjkt
pushed a commit
to CESNET/netconf-cli
that referenced
this pull request
Jan 18, 2022
New Boost does not revert iterators in some cases, so reverting must be done manually. About the command_completion change: I have no idea, but the 1.77 fix works for 1.78. This actually needs this patch boostorg/spirit#711. No idea how to inject that to the CI. Issue: boostorg/spirit#703 (comment) Change-Id: I2d1266b1f8b893f180ae36842bdfdb35c5629ea4
jktjkt
added a commit
to CESNET/netconf-cli
that referenced
this pull request
Jun 21, 2023
Up to Boost 1.77, it was enough to just call this from the `on_success`
handler:
_pass(context) = false;
...and the spirit-x3 core would auto-revert the iterators. The sky was
pink and the unicorns were flying with their horns upright. Starting
with 1.78, though, the auto-reposition of the input iterators was
removed, which necessitated resetting them by hand. However, this
required casting away the constness of the `after` iterator because the
function signature was just wrong, passing a non-const iterator
reference for the `before` iterator (which we do not need to modify),
and a const one for the `after` iterator that we do want to modify.
Functions with a non-const reference to the `after` iterator wouldbe
silently ignored ("hey, it's just a function that I'm not calling, no
***** given").
That was fixed in 1.80, but we want to make sure that we work on the
latest Fedora which only has Boost 1.78, even though upstream already
released Boost 1.82.
Fix that by using `const` function signatures, but cast that const away
at runtime.
Also for consistency, always overwrite that iterator whenever rejecting
the input -- no matter whether the current version of Boost needs it or
not, and even in cases where the previous version of code would "just"
reject parsing, but keep the after iterator on its new value.
Bug: boostorg/spirit#711
Bug: boostorg/spirit#703
Fixes: 5b8e282 Fix for Boost 1.78
Change-Id: Ib603db643a086e0351a4d74082505329ab8944cb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of usual
[current, end)pair it receives[before, current)pair.Fixes #703 (comment)