WIP: Collect at most as many frames as requested. #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanEisenhauer
commented
Oct 29, 2018
| @@ -72,7 +73,7 @@ class basic_stacktrace { | |||
| try { | |||
| { // Fast path without additional allocations | |||
| native_frame_ptr_t buffer[buffer_size]; | |||
| const std::size_t frames_count = boost::stacktrace::detail::this_thread_frames::collect(buffer, buffer_size, frames_to_skip + 1); | |||
| const std::size_t frames_count = boost::stacktrace::detail::this_thread_frames::collect(buffer, std::min(buffer_size, max_depth), frames_to_skip + 1); | |||
There was a problem hiding this comment.
Enables users on older Windows platforms to use small enough maximum stack depth.
1 similar comment
|
Awesome! Many thanks for the patch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regardless of any user provided maximum stack depth
boost::stacktrace::basic_stacktrace<>::initwill try to obtain 128 stack frames.For older Microsoft platforms like Windows Server 2003 and Windows XP this is problematic as
RtlCaptureStackBacktracehas a stricter limit on the stack depth.