Revert change to elide a warning that caused Solaris builds to fail. #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is a single CI failure, 388.10 - but that doesn't look like it could be related to the change in this PR. |
ftrader
pushed a commit
to bitcoin-cash-node/bitcoin-cash-node
that referenced
this pull request
May 29, 2022
Summary --- In glibc >= 2.34 `PTHREAD_STACK_MIN` has been made dynamic which causes Boost 1.70 to fail to build. This has been fixed in boostorg/thread#297 for Solaris which also uses a function call for `PTHREAD_STACK_MIN`. See: * fabaff/nixpkgs@629e531 * boostorg/thread#364 * boostorg/thread#283 Test plan --- * Use a build OS that includes glibc >= 3.34 * `cd depends` * `make build-linux64`
KarolTrzeszczkowski
pushed a commit
to Ergon-moe/Bitcoin-Static
that referenced
this pull request
Jul 2, 2022
Summary --- In glibc >= 2.34 `PTHREAD_STACK_MIN` has been made dynamic which causes Boost 1.70 to fail to build. This has been fixed in boostorg/thread#297 for Solaris which also uses a function call for `PTHREAD_STACK_MIN`. See: * fabaff/nixpkgs@629e531 * boostorg/thread#364 * boostorg/thread#283 Test plan --- * Use a build OS that includes glibc >= 3.34 * `cd depends` * `make build-linux64`
sickpig
pushed a commit
to BitcoinUnlimited/BitcoinUnlimited
that referenced
this pull request
Apr 2, 2023
Summary --- In glibc >= 2.34 `PTHREAD_STACK_MIN` has been made dynamic which causes Boost 1.70 to fail to build. This has been fixed in boostorg/thread#297 for Solaris which also uses a function call for `PTHREAD_STACK_MIN`. See: * fabaff/nixpkgs@629e531 * boostorg/thread#364 * boostorg/thread#283 Test plan --- * Use a build OS that includes glibc >= 3.34 (eg Ubuntu 22.04) * `cd depends` * `make HOST=x86_64-pc-linux-gnu`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert a minor change to elide a warning regarding comparison of unsigned to zero that caused solaris platforms to fail to build.
#283