Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/cfoa #188

Merged
merged 330 commits into from
Jun 17, 2023
Merged

Feature/cfoa #188

merged 330 commits into from
Jun 17, 2023

Conversation

joaquintides
Copy link
Member

No description provided.

cmazakas and others added 30 commits March 22, 2023 11:20
@cmazakas
Fix typo in GHA ci.yml
ff356ac
@joaquintides
tried relaxing atomic operations
44b9188
@joaquintides
Merge branch 'feature/cfoa' of https://github.com/boostorg/unordered …
52453cb 
…into feature/cfoa
@joaquintides
partially reverted prior commit to nail down problem with Clang x86
41584e7
@joaquintides
partially restored prior commit to nail down problem with Clang x86
4a7116b
@cmazakas
Explicitly add B2_TARGETS to script invocation
f2d4f19
@cmazakas
update clang tsan job to use libc++
e1f11e8
@cmazakas
Add tsan OSX job
9e6b5a7
@cmazakas
Attempt to add tsan to Drone CI
1070c9b
@cmazakas
Fix missing quotes in jsonnet file
99eab2d
@joaquintides
abode by TSan on Neon
297fb2e
@cmazakas
Add missing stdlib= to drone.sh
eedbc6b
@cmazakas
Add insert(initializer_list)
d9515fd
@cmazakas
Flesh out tests for insertion
ad86f92
@cmazakas
Avoid unsupported typedef on earlier compilers
99d5b9b
@joaquintides
relaxed all ops of atomic_integral
d085c40
@joaquintides
(partially) implemented shared/exclusive visitation
49ac103
@cmazakas
Partially implement insert_or_assign()
8b55397
@joaquintides
completed shared/exclusive visitation
7415721
@joaquintides
moved erase_if_impl from foa::table_core into foa::table
240f5f9
@joaquintides
fixed previous commit
88c70b8
@joaquintides
fixed previous commit
a85df27
@joaquintides
avoided sign conversion warning
ae9f350
@joaquintides
fixed remaining errors in erase_if(foa::table&,...)
37ff9de
@joaquintides
changed predicate arg to an lvalue ref to avoid ADL ambiguities
8dbe380
@joaquintides
fixed const-casting in erase_if(foa::table&,...)
40c5c69
@joaquintides
refactored visitation an const-protection of args to visitation funct…
5f4172c 
…ions
@joaquintides
stylistic
02c3bd4
@joaquintides
fixed call ambiguities in insert_or_visit
45ebc1e
@cmazakas
Add transparent insert_or_assign
ce674c8
@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://188.unordered.prtest2.cppalliance.org/libs/unordered/doc/html/unordered.html

joaquintides
joaquintides commented Jun 9, 2023
View reviewed changes
Copy link
Member Author

@joaquintides joaquintides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good. Things I have not reviewed:

  • Tests. They're quite dauting to me, but I've seen Chris progress through testing and feel confident he's tapped into all there is to exercise.
  • Docs, but these have been reviewed over several times.
  • Code under folder foa, which is primarly mine. Would be great if @pdimov and/or @cmazakas could take a look there.

include/boost/unordered/concurrent_flat_map.hpp Outdated Show resolved Hide resolved
include/boost/unordered/concurrent_flat_map.hpp Show resolved Hide resolved
include/boost/unordered/concurrent_flat_map.hpp Outdated Show resolved Hide resolved
include/boost/unordered/concurrent_flat_map.hpp Show resolved Hide resolved
include/boost/unordered/concurrent_flat_map.hpp Show resolved Hide resolved
include/boost/unordered/concurrent_flat_map.hpp Outdated Show resolved Hide resolved
include/boost/unordered/concurrent_flat_map_fwd.hpp Outdated Show resolved Hide resolved
include/boost/unordered/detail/fwd.hpp Show resolved Hide resolved
include/boost/unordered/concurrent_flat_map.hpp Show resolved Hide resolved
include/boost/unordered/concurrent_flat_map.hpp Outdated Show resolved Hide resolved
@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://188.unordered.prtest2.cppalliance.org/libs/unordered/doc/html/unordered.html

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://188.unordered.prtest2.cppalliance.org/libs/unordered/doc/html/unordered.html

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://188.unordered.prtest2.cppalliance.org/libs/unordered/doc/html/unordered.html

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://188.unordered.prtest2.cppalliance.org/libs/unordered/doc/html/unordered.html

@joaquintides joaquintides merged commit d65d9a6 into develop Jun 17, 2023
66 of 70 checks passed
@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://188.unordered.prtest2.cppalliance.org/libs/unordered/doc/html/unordered.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hadrielk hadrielk hadrielk left review comments

@pdimov pdimov Awaiting requested review from pdimov

@cmazakas cmazakas Awaiting requested review from cmazakas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@joaquintides @cppalliance-bot @cmazakas @pdimov @hadrielk