Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bounds-check after arithmetic is complete #4

Merged
merged 1 commit into from Dec 9, 2014
Merged

Bounds-check after arithmetic is complete #4

merged 1 commit into from Dec 9, 2014

Commits on Dec 8, 2014

  1. Bounds-check after arithmetic is complete 

    double_to_size can return std::numeric_limits<size_t>max(), so we cannot add 1 to the return value of double_to_size. That addition should be done while still working with a double, as can be seen being done on line 850 of this file.
This was uncovered by Coverity, and addresses Coverity issues CID13443 and CID12664
    @tempoz
    tempoz committed Dec 8, 2014
    Copy the full SHA
    3a507b4 View commit details
    Browse the repository at this point in the history