refactor: no implicit char conversions

fix #816
boostorg · Feb 7, 2024 · 2ecc9ad · 2ecc9ad
1 parent 47c8323
commit 2ecc9ad
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 4 deletions.
diff --git a/include/boost/url/detail/encode.hpp b/include/boost/url/detail/encode.hpp
@@ -115,8 +115,9 @@ re_encode_unsafe(
         detail::hexdigs[opt.lower_case];
     auto const encode = [end, hex](
         char*& dest,
-        unsigned char c) noexcept
+        char c0) noexcept
     {
+        auto c = static_cast<unsigned char>(c0);
         ignore_unused(end);
         *dest++ = '%';
         BOOST_ASSERT(dest != end);

diff --git a/include/boost/url/grammar/lut_chars.hpp b/include/boost/url/grammar/lut_chars.hpp
@@ -116,8 +116,8 @@ class lut_chars
         unsigned char ch) noexcept
     {
         return ch == 255
-            ? construct(ch, pred(ch))
-            : construct(ch, pred(ch)) +
+            ? construct(ch, pred(static_cast<char>(ch)))
+            : construct(ch, pred(static_cast<char>(ch))) +
                 construct(pred, ch + 1);
     }
 
@@ -257,6 +257,14 @@ class lut_chars
     bool
     operator()(
         unsigned char ch) const noexcept
+    {
+        return operator()(static_cast<char>(ch));
+    }
+
+    /// @copydoc operator()(unsigned char) const
+    constexpr
+    bool
+    operator()(char ch) const noexcept
     {
         return mask_[lo(ch)] & hi(ch);
     }

diff --git a/test/unit/test_rule.hpp b/test/unit/test_rule.hpp
@@ -60,7 +60,7 @@ test_char_set(
     for_each_char(
     [&cs](char c)
     {
-        if(cs(0) || ! cs(c))
+        if(cs(static_cast<unsigned char>(0)) || ! cs(c))
         {
             if(cs(c))
             {