Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed NO_VOID_RETURNS workaround #56

Merged
merged 1 commit into from Jan 6, 2019

Conversation

Projects
None yet
3 participants
@Kojoley
Copy link
Contributor

Kojoley commented Jan 5, 2019

The workaround is obsolete, from Boost.Config it looks like it was used for very old EDG2.4, VC6, and other compilers in VC6 emulation mode.

I have checked MSVC 9.0, GCC 4.1.2, Clang 3.0.0, and ICC 13.0.1 - all of them do allow void return. https://godbolt.org/z/9zS4TS

Removed NO_VOID_RETURNS workaround
The workaround is obsolete, from Boost.Config it looks like it was used for
very old EDG2.4, VC6, and other compilers in VC6 emulation mode.
@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 5, 2019

Coverage Status

Coverage remained the same at 95.063% when pulling c4370b2 on Kojoley:remove-no-void-returns-workaround into 6900641 on boostorg:develop.

@apolukhin apolukhin self-assigned this Jan 6, 2019

@apolukhin apolukhin merged commit 500778b into boostorg:develop Jan 6, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 95.063%
Details
@apolukhin

This comment has been minimized.

Copy link
Member

apolukhin commented Jan 6, 2019

Awesome! Many thanks!

@Kojoley Kojoley deleted the Kojoley:remove-no-void-returns-workaround branch Jan 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.