Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 1.85 fixes #209

Merged
merged 8 commits into from
Apr 1, 2024
Merged

Merge 1.85 fixes #209

merged 8 commits into from
Apr 1, 2024

Conversation

jefftrull
Copy link
Collaborator

In this release we fix two filed bugs and some other problems: a broken CI, removed filesystem API call, and a potential vulnerability.

jefftrull and others added 8 commits January 14, 2024 15:06
- convenience.hpp is removed
- no_push and branch_path are removed
…oval

Handle some previously deprecated, now removed, filesystem code
* Update runner OS options so all jobs execute

* Add C++20 to matrix

* Add gcc-9 and msvc-14.3 (via Appveyor) to matrix
This line was inadvertently removed in 1.84 as part of another bug
fix. This change restores it and improves the associated unit test.
There is no guarantee (indeed, it is unlikely) that data within the
scanner buffer will be null terminated, and so the constructor that
accepts a pointer and a count is appropriate.
* Check for backslash characters before the start of the new data

With BOOST_WAVE_BSIZE set to 40, test t_5_002 fails because a newline appears exactly at the beginning of a newly
fetched buffer, and a backslash is at the end of the previous one. In that case the escaped newline
was not detected. This change will also consider three unprocessed bytes of input data, if available,
prior to the new data, which is enough to detect a trigraph backslash.

* Improve data range check for backslash newline

The existing check considered the space required for a trigraph backslash, but not for the following LF (or CRLF) before testing for them. With BOOST_WAVE_BSIZE set to 98 this caused a segfault in t_5_001.
* Update marker before and after fill() operation in cpplexer

* A basic test case for trigraph "pound" (octothorpe) on fill boundary (detects the marker issue)

This change resolves #202 

---------

Co-authored-by: Chris Chisolm <chris_chisolm@intuit.com>
Co-authored-by: Jeff Trull <edaskel@att.net>
@jefftrull jefftrull merged commit c11757d into master Apr 1, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants