Proper VMware support #747

frapposelli · 2015-02-19T00:14:25Z

As mentioned in #638 and #659 this PR adds support for VMware Tools in the most comprehensive manner given the current limitation of TCL 5.x.

Features:

Add vmtoolsd for backdoor communication with the hosting hypervisor.
The open-vm-tools build is embedded in the Dockerfile (no longer tied to vmware/tcl-container).
A wrapper for the shutdown command, to gracefully shutdown and reboot the GOS when issuing commands using tools.
Memory balloon kernel module (vmw_balloon).
A slightly modified automount script that verifies if the disk is provided by a VMware hypervisor, throughly checks if empty and formats it for use with B2D.

Missing:

Shared Folders (vmhgfs) support as we need 64bit userspace and kernel to make it work (will follow up with a PR on that too).

Fixes #638 and #659

References:
docker/machine#507
docker/machine#532
docker/machine#461
docker/machine#430

SvenDowideit · 2015-02-19T00:59:20Z

cool! how big does this make the iso?

and have you had a chance to test it with the 64 bit work from @afressancourt ?

romant · 2015-02-19T03:19:42Z

+1

frapposelli · 2015-02-19T10:34:06Z

@SvenDowideit size has not increased much:

$~ ls -al boot2docker.iso
-rw-r--r--  1 frapposelli  staff  25165824 Feb 19 11:31 boot2docker.iso

And yes, I have a 64 bit working install based on @afressancourt work that has everything including shared folders support, is there a 64 bit branch I can send that PR to?

afressancourt · 2015-02-19T11:05:00Z

Hello Fabio,

Do you have the Dockerfile somewhere that I could build upon in parallel of the pullrequest process? Thanks a lot, and congratulations, I am struggling with shared folder support and acpid since the beginning of the week !

frapposelli · 2015-02-19T11:09:14Z

@afressancourt I need to do some merging before pushing the branch to github but I'll update you once it's there.

BTW, when I say everything working including shared folders support it's in regard to the scope of this PR so VMware Tools, I haven't played with it on Virtualbox 😄

afressancourt · 2015-02-19T12:55:56Z

My own pull request
#748

frapposelli · 2015-02-23T01:51:56Z

@SvenDowideit @tianon have you guys had the chance to review this?

rootfs/rootfs/usr/local/bin/lsb_release

@@ -0,0 +1,8 @@
+#!/bin/sh
+# just to make open-vm-tools happy, nad fake output


SvenDowideit · 2015-02-23T04:40:16Z

yeah, LGTM - though I've not had a system setup to test it. @tianon ?

tianon · 2015-02-23T17:05:52Z

... (no longer tied to vmware/tcl-container).

We still are though, right? (since we're downloading resources from that repo)

I wasn't opposed to keeping that built externally especially since it keeps the diff here down to just the elements that matter for boot2docker explicitly, and I trust you guys to maintain it appropriately.

The approach here seems reasonably sane, although adding the full build here has turned it into a bit of a patch-bomb. 😄

Showing 8 changed files with 754 additions and 2 deletions.

frapposelli · 2015-02-23T23:00:24Z

@tianon on the ties to vmware/tcl-container, I will refactor it a bit and make it rely on a single patch file, I'd rather keep the build process as part of boot2docker, it is easier to maintain for us in the long run 😄

tianon · 2015-02-23T23:01:03Z

Heh OK, that's fair. 👍

Signed-off-by: Fabio Rapposelli <fabio@vmware.com>

- fake a lsb_release script to make open-vm-tools happy - start vmtoolsd on boot - add shutdown script wrapper for busybox Signed-off-by: Fabio Rapposelli <fabio@vmware.com>

Signed-off-by: Fabio Rapposelli <fabio@vmware.com>

frapposelli · 2015-02-24T09:34:25Z

Here it is, bundled the patches and did some general cleanup, most of the LOC come from the network script that we added 😉

Dockerfile

+RUN mkdir -p /vmtoolsd && cd /vmtoolsd && \
+    curl -L -o open-vm-tools-$OVT_VERSION.tar.gz http://downloads.sourceforge.net/open-vm-tools/open-vm-tools-$OVT_VERSION.tar.gz && \
+    tar xfz open-vm-tools-$OVT_VERSION.tar.gz && rm open-vm-tools-$OVT_VERSION.tar.gz &&\
+    mv open-vm-tools-$OVT_VERSION open-vm-tools


frapposelli · 2015-02-26T15:14:21Z

Alright, spit and polish all around, should be ready for prime time this time 😄

tianon · 2015-02-27T00:55:58Z

LGTM

How hard will it be to port to a proper 64bit userspace?

frapposelli · 2015-02-27T01:06:29Z

@tianon has been done already 😄 I have a branch running at https://github.com/frapposelli/boot2docker/tree/vmware-64bit based on the work made by @afressancourt

It's actually better as it supports shared folders (can't make them work with the current 64bit kernel/32bit userspace situation).

md5 · 2015-02-27T01:16:28Z

It's actually better as it supports shared folders (can't make them work with the current 64bit kernel/32bit userspace situation).

🙌

frapposelli · 2015-02-27T17:41:35Z

I just realized I left out an important bit from the auto mount script, need to fix it before merging.

- Embed patch to network suspend/resume script and removed file - Fix `$()` in automount - Added comments to `vmtoolsd` startup script - Small tweaks in Dockerfile Signed-off-by: Fabio Rapposelli <fabio@vmware.com>

frapposelli · 2015-02-27T19:34:25Z

Fixed the automount script, forgot that we have a different SCSI VID and PID in ESX :-).

Tested with Fusion, Workstation, Player and ESX, so LGTM :-)

rootfs/rootfs/etc/rc.d/automount

+
+        DISK_VENDOR=$(cat /sys/class/block/$(basename $UNPARTITIONED_HD /dev/)/device/vendor /sys/class/block/$(basename $UNPARTITIONED_HD /dev/)/device/model | tr -d "\n")
+        # Test if disk is "VMware, VMware Virtual S" and empty.
+        if [ "$DISK_VENDOR" = "VMware, VMware Virtual S" ] || [ "$DISK_VENDOR" = "VMware  Virtual disk    " ]; then


dreampuf · 2015-03-12T09:31:22Z

I'm exciting to see this PR get merge for shared folder feature.
Thank you for great job !

weikinhuang · 2015-04-02T12:35:45Z

Has there been any updates on this?

dizzyd · 2015-04-07T14:56:50Z

bump :)

mikeys · 2015-04-08T08:01:35Z

Wondering about this myself... Currently it's very difficult to utilise boot2docker in development environment due to the slowness of VirtualBox's shared folders implementation.

tianon · 2015-04-13T19:57:46Z

Ok, this LGTM now; I'm planning to merge as soon as 1.6 is finished and released.

frapposelli · 2015-04-17T08:46:44Z

Great, thanks @tianon !

tianon · 2015-04-17T16:32:09Z

Hey thanks for the poke @frapposelli, and sorry we were already committed and frozen for 1.6 😞. Onward to merge, though!

Proper VMware support

md5 · 2015-04-17T17:37:34Z

🎉

cmluciano · 2015-07-07T15:27:05Z

Are there any docs for using this within boot2docker? I tried changing my driver using boot2docker config to no avail.

This was referenced Feb 19, 2015

'Bad certificate' after stopping and starting vmwarefusion machine docker/machine#430

Closed

vmware fusion machine loses keys when stopped/restarted docker/machine#532

Closed

vmwareFusion 'stop' too harsh docker/machine#507

Closed

frapposelli changed the title ~~Proper VMware Tools support~~ Proper VMware support Feb 19, 2015

SvenDowideit reviewed Feb 23, 2015
View reviewed changes

rootfs/rootfs/usr/local/bin/lsb_release

@@ -0,0 +1,8 @@

#!/bin/sh

# just to make open-vm-tools happy, nad fake output

This comment was marked as spam.

Sign in to view

frapposelli added 4 commits February 24, 2015 10:27

Add open-vm-tools build to Dockerfile

68fa4ad

Signed-off-by: Fabio Rapposelli <fabio@vmware.com>

Added Memory Balloon driver to Kernel

4820bff

Signed-off-by: Fabio Rapposelli <fabio@vmware.com>

Add user space scripts and helpers:

eba9ab5

- fake a lsb_release script to make open-vm-tools happy - start vmtoolsd on boot - add shutdown script wrapper for busybox Signed-off-by: Fabio Rapposelli <fabio@vmware.com>

Modify automount script to initialize empty VMware disks

b48e803

Signed-off-by: Fabio Rapposelli <fabio@vmware.com>

tianon reviewed Feb 24, 2015
View reviewed changes

Fixes after code review:

e883254

- Embed patch to network suspend/resume script and removed file - Fix `$()` in automount - Added comments to `vmtoolsd` startup script - Small tweaks in Dockerfile Signed-off-by: Fabio Rapposelli <fabio@vmware.com>

frapposelli mentioned this pull request Mar 1, 2015

vSphere driver fixes docker/machine#674

Merged

tiborvass reviewed Mar 6, 2015
View reviewed changes

frapposelli mentioned this pull request Apr 15, 2015

host volumes not working with vmwarefusion driver docker/machine#641

Closed

frapposelli mentioned this pull request Apr 17, 2015

vmwarefusion boot2docker running docker 1.5.0 docker/machine#1020

Closed

tianon added a commit that referenced this pull request Apr 17, 2015

Merge pull request #747 from frapposelli/vmware-support

a142bc9

Proper VMware support

tianon merged commit a142bc9 into boot2docker:master Apr 17, 2015

tianon mentioned this pull request Dec 8, 2017

Allow auto disk formatting if there's no magic string (blank disk) #659

Closed

		@@ -0,0 +1,8 @@
		#!/bin/sh
		# just to make open-vm-tools happy, nad fake output

Proper VMware support #747

Proper VMware support #747

Conversation

frapposelli commented Feb 19, 2015

SvenDowideit commented Feb 19, 2015

romant commented Feb 19, 2015

frapposelli commented Feb 19, 2015

afressancourt commented Feb 19, 2015

frapposelli commented Feb 19, 2015

afressancourt commented Feb 19, 2015

frapposelli commented Feb 23, 2015

This comment was marked as spam.

SvenDowideit commented Feb 23, 2015

tianon commented Feb 23, 2015

frapposelli commented Feb 23, 2015

tianon commented Feb 23, 2015

frapposelli commented Feb 24, 2015

This comment was marked as spam.

This comment was marked as spam.

frapposelli commented Feb 26, 2015

tianon commented Feb 27, 2015

frapposelli commented Feb 27, 2015

md5 commented Feb 27, 2015

frapposelli commented Feb 27, 2015

frapposelli commented Feb 27, 2015

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

dreampuf commented Mar 12, 2015

weikinhuang commented Apr 2, 2015

dizzyd commented Apr 7, 2015

mikeys commented Apr 8, 2015

tianon commented Apr 13, 2015

frapposelli commented Apr 17, 2015

tianon commented Apr 17, 2015

md5 commented Apr 17, 2015

cmluciano commented Jul 7, 2015