Skip to content
This repository has been archived by the owner on Sep 26, 2021. It is now read-only.

vSphere driver fixes #674

Merged
merged 1 commit into from Mar 2, 2015
Merged

vSphere driver fixes #674

merged 1 commit into from Mar 2, 2015

Conversation

frapposelli
Copy link
Contributor

Driver rework to use upcoming boot2docker/boot2docker#747 patch:

  • Aligned VMX template to Fusion (vmxnet3, pvscsi)
  • Bundle ssh keys in a tar and upload it through vmtools
  • Power operations moved to graceful shutdown and restart

Integration test:

frapposelli > ~/Develop../goworks../src/github.../docker/machine > vsphere-driver-fixes > MACHINE_BINARY="$(pwd)/docker-machine_darwin-amd64" MACHINE_TESTS="vmwarevsphere" ./script/run-integration-tests
=== RUN TestMachineCreate
 - testing create for vmwarevsphere (machine-test-1425206850048460933-vmwarevsphere)
--- PASS: TestMachineCreate (142.24s)
=== RUN TestMachineStop
 - testing stop for vmwarevsphere (machine-test-1425206850048460933-vmwarevsphere)
--- PASS: TestMachineStop (30.14s)
=== RUN TestMachineStart
 - testing start for vmwarevsphere (machine-test-1425206850048460933-vmwarevsphere)
--- PASS: TestMachineStart (55.15s)
=== RUN TestMachineKill
 - testing kill for vmwarevsphere (machine-test-1425206850048460933-vmwarevsphere)
--- PASS: TestMachineKill (32.59s)
=== RUN TestMachineRemove
 - testing rm for vmwarevsphere (machine-test-1425206850048460933-vmwarevsphere)
--- PASS: TestMachineRemove (30.39s)
PASS
ok      github.com/docker/machine/_integration-test     290.518s

@frapposelli
Driver rework to use upcoming boot2docker/boot2docker#747 patch:
28fff16 
- Aligned VMX template to Fusion (vmxnet3, pvscsi)
- Bundle ssh keys in a tar and upload it through vmtools
- Power operations moved to graceful shutdown and restart

Signed-off-by: Fabio Rapposelli <fabio@vmware.com>
@ehazlett
Copy link
Contributor

ehazlett commented Mar 2, 2015

LGTM

ehazlett added a commit that referenced this pull request Mar 2, 2015
@ehazlett
Merge pull request #674 from frapposelli/vsphere-driver-fixes
4cf7caa 
vSphere driver fixes
@ehazlett ehazlett merged commit 4cf7caa into docker:master Mar 2, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
driver/vmwarefusion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@frapposelli @ehazlett @bfirsh