Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inconsistant punctuation processing #26

Closed
mmmaat opened this issue Oct 23, 2019 · 0 comments
Closed

inconsistant punctuation processing #26

mmmaat opened this issue Oct 23, 2019 · 0 comments

Comments

@mmmaat
Copy link
Collaborator

mmmaat commented Oct 23, 2019

When a point is separating two sentences (in a single line of text), the output gives a single utterance. But when replacing the point by a comma or a semicolon, this outputs 2 utterances. See below:

$ echo 'a comma a point.' | phonemize
ɐ kɑːmə ɐ pɔɪnt 
$ echo 'a comma. a point.' | phonemize
ɐ kɑːmə ɐ pɔɪnt 
$ echo 'a comma; a point.' | phonemize
ɐ kɑːmə 
ɐ pɔɪnt 
$ echo 'a comma, a point.' | phonemize
ɐ kɑːmə 
ɐ pɔɪnt 
$ echo 'a comma? a point!' | phonemize
ɐ kɑːmə 
ɐ pɔɪnt 

The expected behavior would be to ignore punctuation.

@mmmaat mmmaat closed this as completed in 8d8cbce Nov 7, 2019
CorentinJ added a commit to resemble-ai/phonemizer that referenced this issue Feb 19, 2020
* fixed bootphon#26

* phonemizer-2.0.1

* phonemizer-2.0.1

* phonemizer-2.0.1

* CI upload to pypi

* fixed bootphon#31

* bugfix in parsing espeak-ng version

* bugfix in parsing espeak-ng version

* update copyright

* WIP

* Allow sampa for espeak

* option to specify an alternative espeak/espeak-ng binary

* deploy only on new tags

* WIP

* Add replacing content

* add PyYaml requirement

* add test and replacement as str

* WIP

* merge PR bootphon#34 from @Rachine

* can specify an alternative festival executable

* bugfix in setup.py

* fixed sampa mapping for French

* corrected ChangeLog

* CI on multiple versions of espeak

* CI on multiple versions of espeak

* minor improvments

* punctuation processing implemented

* release phonemizer-2.1

* updated README

* updated CHANGELOG

* fixing gitlab CI

* fixing gitlab CI

* fixed issue bootphon#39

* pep8

* fixed issue bootphon#40

* fixed a test on espeak>=1.50

Co-authored-by: Mathieu Bernard <mathieu.a.bernard@inria.fr>
Co-authored-by: Rachid Riad <riadrachid3@gmail.com>
ZohaibAhmed pushed a commit to resemble-ai/phonemizer that referenced this issue Feb 17, 2021
* fixed bootphon#26

* phonemizer-2.0.1

* phonemizer-2.0.1

* phonemizer-2.0.1

* CI upload to pypi

* fixed bootphon#31

* bugfix in parsing espeak-ng version

* bugfix in parsing espeak-ng version

* update copyright

* WIP

* Allow sampa for espeak

* option to specify an alternative espeak/espeak-ng binary

* deploy only on new tags

* WIP

* Add replacing content

* add PyYaml requirement

* add test and replacement as str

* WIP

* merge PR bootphon#34 from @Rachine

* can specify an alternative festival executable

* bugfix in setup.py

* fixed sampa mapping for French

* corrected ChangeLog

* CI on multiple versions of espeak

* CI on multiple versions of espeak

* minor improvments

* punctuation processing implemented

* release phonemizer-2.1

* updated README

* updated CHANGELOG

* fixing gitlab CI

* fixing gitlab CI

* fixed issue bootphon#39

* pep8

* fixed issue bootphon#40

* fixed a test on espeak>=1.50

Co-authored-by: Mathieu Bernard <mathieu.a.bernard@inria.fr>
Co-authored-by: Rachid Riad <riadrachid3@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant