Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor quantity input #405

Merged
merged 4 commits into from
Feb 28, 2023
Merged

Refactor quantity input #405

merged 4 commits into from
Feb 28, 2023

Conversation

crftwrk
Copy link
Member

@crftwrk crftwrk commented Feb 21, 2023

This PR refactor the quantity-input in product and cart pages. quantity-input.php was updated in in each of the last 5 WooCommerce releases. This has no breaking changes, no visual/functional changes in the frontend and works fine.

  • quantity-input.php template has been deleted
  • Using a filter is to add the -/+ buttons
  • @extend for form-control and input-group
  • Minor improvement using Sass variables for margin

Test

Check the product types and click the -/+ buttons and add them to the cart.

@crftwrk crftwrk mentioned this pull request Feb 21, 2023
59 tasks
Copy link
Member

@justinkruit justinkruit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me 👍

@justinkruit justinkruit merged commit ebe0a17 into main Feb 28, 2023
@crftwrk crftwrk deleted the Refactor-quantity-input branch April 11, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants