-
-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to Gutenberg block widgets #662
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@crftwrk you still got more changes to do? 😉 |
@justinkruit not yet, it‘s good for now. |
justinkruit
reviewed
Jan 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only got the one comment, other than that; impressive!
justinkruit
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #471
Because #660 disables classic widgets we should provide support for block widgets. This PR adds Bootstrap to following block widgets:
form-control/btn-outline-secondary/input-group/btn text/icon
select/list-group
select/list-group
list-group
list-group
table
Demo: https://dev.bootscore.me/theme/blocks/
In the sidebar are the widgets that come with a new WP installation wrapped in
.card
, in main content are the same widgets with different/advanced settings.I have stolen this idea from the Understrap theme using
render_block_core
for this purpose and adapted it to our needs.Cards in sidebar
To get widgets in sidebar work properly,
.card
component has been removed in widget register. Cards can be added by using Group blocks and adding classes to the blocks advanced settings:Search form
Replacing the WP search icon with Font Awesome works only if svg is formatted this way. Overriding function in child must have same formatting, including the indentation tab for the function. Don't ask me why.
What else?
_recycle_bin.scss
into_deprecated.scss
_wc_recycle_bin.scss
into_wc_deprecated.scss
@justinkruit IYLIMI