Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to WC categories block widgets #670

Merged
merged 10 commits into from
Jan 23, 2024

Conversation

crftwrk
Copy link
Member

@crftwrk crftwrk commented Jan 13, 2024

Similar to #662, this PR adds support to Woo categories list/select widget block.

See https://dev.bootscore.me/theme/blocks/. The widgets are at the end of the sidebar and at the end of the main content are the same widgets with different settings.

Think we should merge this and add filters in #575. After #575 is merged we should update the libraries, do a PR with changing the logo and go for a new release, agree?

@justinkruit IYLIMI!

@crftwrk crftwrk marked this pull request as draft January 13, 2024 09:27
@crftwrk crftwrk changed the title Add support to some Woo block widgets Add support to WC categories block widgets Jan 15, 2024
@crftwrk crftwrk marked this pull request as ready for review January 15, 2024 09:21
Copy link
Member

@justinkruit justinkruit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the product-categories I'm missing a hover bg color on the button.

Think we should merge this and add filters in #575. After #575 is merged we should update the libraries, do a PR with changing the logo and go for a new release, agree?

Yes I agree. Planning this for February?

@crftwrk
Copy link
Member Author

crftwrk commented Jan 21, 2024

You're right. input-group-text has no hover state. Changed the button to btn-outline-secondary similar to the search form. Check https://dev.bootscore.me/theme/blocks/

Yes I agree. Planning this for February?

Perfect

Copy link
Member

@justinkruit justinkruit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All seems good

@justinkruit justinkruit merged commit d502099 into main Jan 23, 2024
@justinkruit justinkruit deleted the Add-support-for-Woo-GB-widgets branch January 23, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants