Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dynamic currency position #718

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

anisur2805
Copy link
Contributor

No description provided.

Copy link
Member

@crftwrk crftwrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@justinkruit are you fine here?

@crftwrk crftwrk mentioned this pull request Mar 4, 2024
@crftwrk crftwrk requested a review from justinkruit March 4, 2024 12:32
@justinkruit
Copy link
Member

justinkruit commented Mar 4, 2024

I want to make sure this is correctly implemented because of the possibility of customizations on custom webshops.

$product_price = apply_filters('woocommerce_cart_item_price', WC()->cart->get_product_price($_product), $cart_item, $cart_item_key);

This line seems to be unused now, so the filter woocommerce_cart_item_price does nothing here.

I'll look closer into it later if that's alright, when I'm not at work 😇

@crftwrk crftwrk merged commit 79b282b into bootscore:v6.0.0-beta1 Mar 5, 2024
justinkruit added a commit that referenced this pull request Mar 5, 2024
justinkruit added a commit that referenced this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants