Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Tax include and exclude subtotal in WC Mini Cart. #737

Merged
merged 2 commits into from
Mar 22, 2024

Conversation

anisur2805
Copy link
Contributor

@crftwrk please review the changes and let me know the feedback.

@crftwrk crftwrk mentioned this pull request Mar 20, 2024
@crftwrk
Copy link
Member

crftwrk commented Mar 20, 2024

@anisur2805 after changing the quantity, currency symbol and amount after comma disappears?

After added to cart After changing the quantity
Bildschirmfoto 2024-03-20 um 17 55 35 Bildschirmfoto 2024-03-20 um 17 55 46

@anisur2805
Copy link
Contributor Author

@crftwrk after trying various methods, I've confirmed that everything is functioning correctly. Would you mind attempting the action again from incognito mode, just to be sure?

image

@crftwrk
Copy link
Member

crftwrk commented Mar 21, 2024

@anisur2805 tested it on different sites on different servers with different settings, but this happens to all of them.

Please check https://dev.bootscore.me/shop/

After added to cart After changing the quantity
Bildschirmfoto 2024-03-21 um 10 33 06 Bildschirmfoto 2024-03-21 um 10 33 20

Edit: This seems happen if prices are set to exclude taxes

Bildschirmfoto 2024-03-21 um 15 02 41

@anisur2805
Copy link
Contributor Author

@crftwrk here is the fix. Please review the changes.

Thank you.

Copy link
Member

@crftwrk crftwrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🙏

@crftwrk crftwrk merged commit 09c4553 into bootscore:v6.0.0-beta1 Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants