Migrate the underlying sass compiler to Embedded Sass instead of SassC #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are some subtle changes to the test output files when this runs because they are currently written from version 1.4.0 and the current version of the gem is 1.4.1. I don't believe this has anything to do with my changes. |
|
This is now running in production on one of my services. So far, so good. 😄 |
|
@jhubert thank you for your contribution, merging this and will work on a deploy on a new version 👍 |
|
Hi there! This change causes blocking execution problems when running in the Docker image |
|
@joarobles Were you able to find a reproduction? I'm seeing a blocking issue in CI since the sass-embedded migration, but I'm struggling to reproduce the issue locally to debug it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SassC has been deprecated and replaced with Dart Sass, which is implemented for ruby through the sass-embedded gem.
This change simply swaps embedded-sass in place of SassC.
This should allow #165 to pass and be merged in.
I added an additional commit:
ad1b61b - The previous test HTML output had the word transparent wrapped in double quotes for reasons I'm not clear on. I don't think that's standard HTML / CSS syntax. When I migrated to Embedded Sass that went away, so I checked in the change.
I'm not sure what practices you follow, but I would recommend a version bump to 1.5 for this if you decide to merge and release it.