-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support :prepend and :append for the select
helper
#325
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks for the PR! ✨
I just found one nitpick in the test. Let me know if you think that needs to be corrected before I merge.
test/bootstrap_selects_test.rb
Outdated
<select class="form-control" id="user_status" name="user[status]"><option value="1">activated</option> | ||
<option value="2">blocked</option></select> | ||
<span class="input-group-addon">After</span> | ||
</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there another </div>
needed here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, absolutely. I added the </div>
and structured the HTML example a little better as well.
Awesome, thank you 🙌 |
@mattbrictson How do we propagate this to the bootstrap-v4 branch? |
@mattbrictson OK, will do. |
@mattbrictson OK, added #327 |
Fixes #147