Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support :prepend and :append for the select helper #325

Merged
merged 1 commit into from
Apr 20, 2017
Merged

Support :prepend and :append for the select helper #325

merged 1 commit into from
Apr 20, 2017

Conversation

donv
Copy link
Collaborator

@donv donv commented Apr 18, 2017

Fixes #147

Copy link
Contributor

@mattbrictson mattbrictson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for the PR! ✨

I just found one nitpick in the test. Let me know if you think that needs to be corrected before I merge.

<select class="form-control" id="user_status" name="user[status]"><option value="1">activated</option>
<option value="2">blocked</option></select>
<span class="input-group-addon">After</span>
</div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there another </div> needed here?

Copy link
Collaborator Author

@donv donv Apr 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, absolutely. I added the </div> and structured the HTML example a little better as well.

@mattbrictson
Copy link
Contributor

Awesome, thank you 🙌

@mattbrictson mattbrictson merged commit 0fba844 into bootstrap-ruby:master Apr 20, 2017
@donv
Copy link
Collaborator Author

donv commented Apr 21, 2017

@mattbrictson How do we propagate this to the bootstrap-v4 branch?

@mattbrictson
Copy link
Contributor

@donv Can you create a new branch from the latest commit of bootstrap-v4 and then cherry pick commit 0fba844 ? Then when you open a PR, make sure the base branch of the PR is set to bootstrap-v4.

That's assuming the cherry-pick goes cleanly. Let me know if it doesn't work out.

@donv
Copy link
Collaborator Author

donv commented Apr 24, 2017

@mattbrictson OK, will do.

@donv
Copy link
Collaborator Author

donv commented Apr 24, 2017

@mattbrictson OK, added #327

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants