Support :append for the `select` helper

[vzelenko]

Is there an easy way to append label to form select helper? The following does not seem to work...

<%
    options = [['first', 1]]
    (2..30).each {|day| options << [day.to_s, day]}
    options << ['last', 31]
%>
<%= f.select :due_day, options, append: 'day', label: 'Due Day' %>

[carloslopes]

Hey @vzelenko,

I think bootstrap doesn't support this. You can achieve this using only HTML?

[vzelenko]

OK, I'll deal with this manually... Thanks.

[carloslopes]

@vzelenko when I talked about the HTML, I didn't want to you deal with this alone.

I just asked for an example of how it's possible to achieve this. Sorry if I wasn't very clear.

Can you give us an example of a working implementation that does this?

[donv]

Hi @carloslopes !

I use this regularly, and it would be great to get it into this gem. Here is a working example for Bootstrap 4 alpha 6:

<div class="input-group">
  <div class="input-group-addon">@</div>
  <select class="form-control custom-select" name="choice">
    <option value="1">First</option>
    <option value="2">Second</option>
    <option value="3">Third</option>
  </select>
  <div class="input-group-addon">@</div>
</div>

[carloslopes]

Hey @donv, I'm not actively working on this gem anymore, sorry :(

@mattbrictson can you take a look on this?

[mattbrictson]

It looks like we support :append for simple fields but not for the select helper. Unfortunately I don't have time right now to dig into why we have this limitation or how to solve it. A naïve approach would be to modify the select helper to add support like this:

diff --git a/lib/bootstrap_form/form_builder.rb b/lib/bootstrap_form/form_builder.rb
index d89c966..e127c7b 100644
--- a/lib/bootstrap_form/form_builder.rb
+++ b/lib/bootstrap_form/form_builder.rb
@@ -71,13 +71,17 @@ module BootstrapForm
     if Gem::Version.new(Rails::VERSION::STRING) >= Gem::Version.new("4.1.0")
       def select_with_bootstrap(method, choices = nil, options = {}, html_options = {}, &block)
         form_group_builder(method, options, html_options) do
-          select_without_bootstrap(method, choices, options, html_options, &block)
+          prepend_and_append_input(options) do
+            select_without_bootstrap(method, choices, options, html_options, &block)
+          end
         end
       end
     else
       def select_with_bootstrap(method, choices, options = {}, html_options = {})
         form_group_builder(method, options, html_options) do
-          select_without_bootstrap(method, choices, options, html_options)
+          prepend_and_append_input(options) do
+            select_without_bootstrap(method, choices, options, html_options)
+          end
         end
       end
     end

Does anyone want to run with this to see if it works, and if so, open a PR?

[donv]

@mattbrictson I'd be happy to do that. My personal focus is on Bootstrap 4. Which branch should I use as base for this?

[mattbrictson]

@donv I would prefer to first try this against master (i.e. Bootstrap 3), since that will be more likely to get merged and released to rubygems quickly.

[donv]

OK, I'll do master first.