-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(BCheckBox*): Small changes to get documentation to parity #1873
Conversation
Run & review this pull request in StackBlitz Codeflow. |
|
||
See the [Vue 3 migration guide](https://v3-migration.vuejs.org/breaking-changes/v-model.html) | ||
for more info. | ||
|
||
<MigrationWrapper v-for="(item, i) in changes" :key="i" v-bind="item" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@VividLemon I didn't follow your pattern with the migration wrapper here. The problem is that vue components are rendered after the markdown is all transformed, so using this technique I don't see any way to get markdown sections (and other markdown, like the examples) into this document.
Let me know if you can think of a way to get the best of both worlds. The only way I could see to do that is to write a markdown-it plugin, which seems like a pretty heavy lift for this, but maybe I'm missing something simple.
<template #html> | ||
|
||
```vue-html | ||
<b-form-checkbox v-model="checked" :indeterminate.sync="indeterminate"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pascal case for consistency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. I went back and forth on this, landing on kebab-case, since that's what the BSV sample that I pulled had. But now that I see this, I agree that it makes the relevant change stand out more.
Co-authored-by: Issayah <github.me.mzu5a@simplelogin.com>
* upstream/main: (23 commits) feat(BInput): Alias BFormInput to BInput fix(nuxt): dont teleport everything to #teleports -- selectively teleport based on body fixes bootstrap-vue-next#1898 chore: release main feat(nuxt): allow passthrough options to createBootstrap plugin chore: release main (bootstrap-vue-next#1894) feat: implmenet a use defaults system WIP fixes bootstrap-vue-next#1607 (bootstrap-vue-next#1889) docs(BCheckBox*): Small changes to get documentation to parity (bootstrap-vue-next#1873) docs: Add component reference link in the page table of contents sidebar fixed BTableLite item _showDetails BTable delete selection when primary-key chore: release main feat(BTable): add change event -- replaces bv `modelValue` see bootstrap-vue-next#1775 (comment) chore: release main fix(BTable): selectedItems not clearing values properly fixes bootstrap-vue-next#1878 (bootstrap-vue-next#1879) chore: release main (bootstrap-vue-next#1874) fix(BTable): Pass through original records to slots in most circumstances (bootstrap-vue-next#1869) chore: release main (bootstrap-vue-next#1867) feat(BTable): Allow dot in sortby key fix: update dependencies to fix a bug in vue compiler (bootstrap-vue-next#1866) chore: release main (bootstrap-vue-next#1859) ...
Describe the PR
This PR should get the documents up to date and confirm that they are at parity with BSV and BS5
AriaInvalid
, which was used but not exportedSmall replication
A small replication or video walkthrough can help demonstrate the changes made. This is optional, but can help observe the intended changes. A mentioned issue that contains a replication also works.
PR checklist
What kind of change does this PR introduce? (check at least one)
fix(...)
feat(...)
fix(...)
docs(...)
The PR fulfills these requirements:
CHANGELOG
is generated from these messages, and determines the next version type. Pull requests that do not follow conventional commits or do not have an override will be denied