Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(BTable): selectedItems not clearing values properly fixes #1878 #1879

Merged
merged 2 commits into from
May 4, 2024

Conversation

VividLemon
Copy link
Member

…es instead

fix(BTable): selectedItems not clearing values properly fixes #1878

fix(BTable): selectedItems with range not displaying class

test(BTableLite): toggle details functionality

test(BTable): selectedItems functioanlity

Describe the PR

A clear and concise description of what the pull request does.

Small replication

A small replication or video walkthrough can help demonstrate the changes made. This is optional, but can help observe the intended changes. A mentioned issue that contains a replication also works.

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix 🐛 - fix(...)
  • Feature - feat(...)
  • ARIA accessibility - fix(...)
  • Documentation update - docs(...)
  • Other (please describe)

The PR fulfills these requirements:

  • Pull request title and all commits follow the Conventional Commits convention or has an override in this pull request body This is very important, as the CHANGELOG is generated from these messages, and determines the next version type. Pull requests that do not follow conventional commits or do not have an override will be denied

…es instead

fix(BTable): selectedItems not clearing values properly fixes bootstrap-vue-next#1878

fix(BTable): selectedItems with range not displaying class

test(BTableLite): toggle details functionality

test(BTable): selectedItems functioanlity
Copy link

stackblitz bot commented May 4, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@VividLemon VividLemon merged commit 3b57599 into bootstrap-vue-next:main May 4, 2024
3 checks passed
@github-actions github-actions bot mentioned this pull request May 4, 2024
xvaara added a commit to xvaara/bootstrap-vue-next that referenced this pull request May 22, 2024
* upstream/main: (23 commits)
  feat(BInput): Alias BFormInput to BInput
  fix(nuxt): dont teleport everything to #teleports -- selectively teleport based on body fixes bootstrap-vue-next#1898
  chore: release main
  feat(nuxt): allow passthrough options to createBootstrap plugin
  chore: release main (bootstrap-vue-next#1894)
  feat: implmenet a use defaults system WIP fixes bootstrap-vue-next#1607  (bootstrap-vue-next#1889)
  docs(BCheckBox*): Small changes to get documentation to parity (bootstrap-vue-next#1873)
  docs: Add component reference link in the page table of contents sidebar
  fixed BTableLite item _showDetails
  BTable delete selection when primary-key
  chore: release main
  feat(BTable): add change event -- replaces bv `modelValue` see bootstrap-vue-next#1775 (comment)
  chore: release main
  fix(BTable): selectedItems not clearing values properly fixes bootstrap-vue-next#1878 (bootstrap-vue-next#1879)
  chore: release main (bootstrap-vue-next#1874)
  fix(BTable): Pass through original records to slots in most circumstances (bootstrap-vue-next#1869)
  chore: release main (bootstrap-vue-next#1867)
  feat(BTable): Allow dot in sortby key
  fix: update dependencies to fix a bug in vue compiler (bootstrap-vue-next#1866)
  chore: release main (bootstrap-vue-next#1859)
  ...
Pequem pushed a commit to Pequem/bootstrap-vue-next that referenced this pull request May 28, 2024
…ap-vue-next#1878 (bootstrap-vue-next#1879)

refactor(BTableLite): remove internal props. Use Weakmap to sync values instead

fix(BTable): selectedItems with range not displaying class

test(BTableLite): toggle details functionality

test(BTable): selectedItems functioanlity
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BTable v-model:selected-items and select-mode single
1 participant