Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaks for collapse to work. #12

Closed
michaelwoodson opened this issue Oct 21, 2016 · 2 comments
Closed

Tweaks for collapse to work. #12

michaelwoodson opened this issue Oct 21, 2016 · 2 comments

Comments

@michaelwoodson
Copy link
Contributor

I was able to get collapse working with the following tweaks:
In collapse.vue change:
hub.$on('toggled::collapse', function (data) {
to:
hub.$on('toggled::collapse', (data) => {

That way this.id returns the expected value.

Also in collapse-toggle.vue there are two calls to emit the "toggled::collapse" events. I had to remove one of the calls.

Similar changes will be needed to the analogous accordion code that seems to be stubbed in.

@pi0
Copy link
Member

pi0 commented Oct 21, 2016

@michaelwoodson Thanks for you point! Is there any chance opening a PR for that bugfix ? So we will able to review and merge it ASAP :)

@michaelwoodson
Copy link
Contributor Author

Sure, I'll make one shortly, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants