New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweaks for collapse to work. #12
Comments
@michaelwoodson Thanks for you point! Is there any chance opening a PR for that bugfix ? So we will able to review and merge it ASAP :) |
Sure, I'll make one shortly, thanks! |
michaelwoodson
added a commit
to michaelwoodson/bootstrap-vue
that referenced
this issue
Oct 21, 2016
…n for collapse, fixes bootstrap-vue#12.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I was able to get collapse working with the following tweaks:
In collapse.vue change:
hub.$on('toggled::collapse', function (data) {
to:
hub.$on('toggled::collapse', (data) => {
That way this.id returns the expected value.
Also in collapse-toggle.vue there are two calls to emit the "toggled::collapse" events. I had to remove one of the calls.
Similar changes will be needed to the analogous accordion code that seems to be stubbed in.
The text was updated successfully, but these errors were encountered: