Remove duplicate emit calls and fix event handler function declaratio…

…n for collapse, fixes bootstrap-vue#12.
michaelwoodson · Oct 21, 2016 · e0b3896 · e0b3896
1 parent 69e0e26
commit e0b3896
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/components/collapse-toggle.vue b/components/collapse-toggle.vue
@@ -27,10 +27,8 @@
         // broadcast accordion toggle if both id and group are set otherwise broadcast collapse
         // we also use dispatch to tell other components about the change
         if (this.target && this.targetGroup) {
-          this.$root.$emit('toggled::accordion', {id: this.target, group: this.targetGroup});
           this.$root.$emit('toggled::accordion', {id: this.target, group: this.targetGroup})
         } else {
-          this.$root.$emit('toggled::collapse', {id: this.target, group: this.targetGroup});
           this.$root.$emit('toggled::collapse', {id: this.target, group: this.targetGroup})
         }
       }

diff --git a/components/collapse.vue b/components/collapse.vue
@@ -52,7 +52,7 @@
     created: function () {
       const hub = this.$root;
 
-      hub.$on('toggled::collapse', function (data) {
+      hub.$on('toggled::collapse', (data) => {
         if (data.id && data.id === this.id && !data.group || data.group && data.group === this.group && !data.id) {
           if ((this.$el.className + ' ').indexOf(' in ') > -1) {
             this.hide()
@@ -62,7 +62,7 @@
         }
       });
 
-      hub.$on('toggled::accordion', function (data) {
+      hub.$on('toggled::accordion', (data) => {
         // if id and group id is provided it means it is an accordion and takes priority over all
         if (data.id && data.group && data.group === this.group) {
           // for current element