Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alert - alerts unexpectedly transitioned and removed #3346

Closed
DM2489 opened this issue May 21, 2019 · 2 comments · Fixed by #3347
Closed

Alert - alerts unexpectedly transitioned and removed #3346

DM2489 opened this issue May 21, 2019 · 2 comments · Fixed by #3347
Labels
Type: Enhancement Type: Feature request

Comments

@DM2489
Copy link
Contributor

DM2489 commented May 21, 2019 •
edited
Loading

Describe the bug

When an alert begins with a countdown, but it's show property is changed to true before the countdown expires, the alert is transitioned and then removed unexpectedly.

Steps to reproduce the bug

  1. Go to https://codesandbox.io/s/qeghj
  2. Observe the countdown timer reduce a few times
  3. Before the countdown expires, press the button to make show === true
  4. Watch as the alert transitions away and is then removed from the dom

Expected behavior

The alert should remain visible when show is changed from an integer value to true.

Versions

Libraries:

  • BootstrapVue: 2.0.0-rc.20
  • Bootstrap: 4.3.1
  • Vue: 2.6.10

https://codesandbox.io/s/qeghj
@DM2489 DM2489 changed the title Alert - alerts unexpectedly transition to hide Alert - alerts unexpectedly transitioned and removed May 21, 2019
tmorehouse added a commit that referenced this issue May 21, 2019
@tmorehouse
fix(b-alert): handle case where dismiss countdown changes to a boolea…
9b9ccb3 
…n value (closes #3346)

Handle edge case where `show` prop changes from a number to a Boolean.

Closes #3346
@tmorehouse tmorehouse mentioned this issue May 21, 2019
Merged
18 tasks
@tmorehouse
Copy link
Member

PR #3347 addresses this, and will be available in the next release

@DM2489
Copy link
Contributor Author

DM2489 commented May 21, 2019

Awesome, thank you so much @tmorehouse!

@DM2489 DM2489 closed this as completed May 21, 2019
tmorehouse added a commit that referenced this issue May 21, 2019
@tmorehouse
fix(b-alert): handle case where dismiss countdown changes to a boolea…
14ad833 
…n value (closes #3346) (#3347)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Enhancement Type: Feature request
Projects
None yet
Milestone
No milestone
2 participants
@tmorehouse @DM2489