Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selectable + transitions issue #4370

Closed
cjaoude opened this issue Nov 11, 2019 · 3 comments · Fixed by #4372, mariazevedo88/hash-generator-js#17 or CloudsdaleGroup/AnimFM#3
Closed

Selectable + transitions issue #4370

cjaoude opened this issue Nov 11, 2019 · 3 comments · Fixed by #4372, mariazevedo88/hash-generator-js#17 or CloudsdaleGroup/AnimFM#3

Comments

@cjaoude
Copy link

@cjaoude cjaoude commented Nov 11, 2019

Possible bug...

Recently updated packages to the latest vue, bootstrap-vue. When updating the tables for certain breaking changes I encountered an issue with selectable rows + transitions. Using a selectable table/rows with transitions breaks select-ability. The select event doesn't appear to fire on the row.

After having the issue with my tables, I created a sanity-check table using the bootstrap-vue documentation table code for transitions. Then I added to it the code from the selectable example, and it breaks as well. Edit out :tbody-transition-props and select-ability works again. Gist example below:

Help resolving and/or confirmation that this is a bug appreciated. #

Sanity-check example table using documentation code:
https://gist.github.com/cjaoude/e85291d5b1413d849a61c5a87b86f15d

        "vue": "^2.6.10",
        "vue-template-compiler": "^2.6.10"
        "bootstrap": "^4.3.1",
        "bootstrap-vue": "^2.0.4",
@tmorehouse

This comment has been minimized.

Copy link
Member

@tmorehouse tmorehouse commented Nov 11, 2019

It appears that there is an issue with event delegation on <tbody> when it is rendered as a <transition-group> compoent (we have the row click handlers delegated to the <tbody> instead of instantiated listeners on each row element)

tmorehouse added a commit that referenced this issue Nov 11, 2019
…n transition + minor adjustment to row `key` generation (fixes #4370) (#4372)
@tmorehouse

This comment has been minimized.

Copy link
Member

@tmorehouse tmorehouse commented Nov 11, 2019

Will be fixed in release 2.1.0 (being released this week)

@tmorehouse

This comment has been minimized.

Copy link
Member

@tmorehouse tmorehouse commented Nov 13, 2019

BootstrapVue v2.1.0 has been released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.