New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dropdown): use class `position-static` instead of inline style #1451

Merged
merged 10 commits into from Dec 12, 2017

Conversation

Projects
None yet
1 participant
@tmorehouse
Member

tmorehouse commented Dec 11, 2017

No description provided.

tmorehouse added some commits Dec 11, 2017

@codecov

This comment has been minimized.

codecov bot commented Dec 12, 2017

Codecov Report

Merging #1451 into dev will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1451      +/-   ##
==========================================
+ Coverage   47.92%   47.96%   +0.04%     
==========================================
  Files         135      135              
  Lines        2500     2500              
  Branches      785      785              
==========================================
+ Hits         1198     1199       +1     
+ Misses        926      925       -1     
  Partials      376      376
Impacted Files Coverage Δ
src/components/dropdown/dropdown.js 100% <100%> (+16.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 260919f...112b2a9. Read the comment docs.

@tmorehouse tmorehouse merged commit fc49325 into dev Dec 12, 2017

4 checks passed

License Compliance License checks passed.
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 47.92%)
Details
codecov/project 47.96% (+0.03%) compared to 260919f
Details

@tmorehouse tmorehouse deleted the fix/dropdown branch Dec 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment