New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore BV keys when auto-discovering table fields #1641

Merged
merged 3 commits into from Feb 28, 2018

Conversation

Projects
None yet
2 participants
@robcresswell
Contributor

robcresswell commented Feb 28, 2018

Bootstrap-Vue has some extra keys that can be provided to enhance table
functionality. These should be explicitly ignored when automatically
discovering the fields for a table, when the fields prop is not
provided.

The reason for explicitly ignoring the keys, rather than blanket
ignoring all keys beginning with "_" is to minimise any possible
collisions with user provided data in that field.

Fixes #1635

Rob Cresswell and others added some commits Feb 28, 2018

Rob Cresswell
Ignore BV keys when auto-discovering table fields
Bootstrap-Vue has some extra keys that can be provided to enhance table
functionality. These should be explicitly ignored when automatically
discovering the fields for a table, when the fields prop is not
provided.

The reason for explicitly ignoring the keys, rather than blanket
ignoring all keys beginning with "_" is to minimise any possible
collisions with user provided data in that field.

Fixes #1635
@codecov

This comment has been minimized.

codecov bot commented Feb 28, 2018

Codecov Report

Merging #1641 into dev will increase coverage by 0.13%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1641      +/-   ##
==========================================
+ Coverage   60.64%   60.78%   +0.13%     
==========================================
  Files         153      153              
  Lines        2869     2871       +2     
  Branches      788      789       +1     
==========================================
+ Hits         1740     1745       +5     
+ Misses        809      806       -3     
  Partials      320      320
Impacted Files Coverage Δ
src/components/table/table.js 72.54% <100%> (+1.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 048c3d4...6e174f4. Read the comment docs.

Rob Cresswell
Add Tests
Also adds *.swp to .gitignore, for vim users like me :)

@mosinve mosinve merged commit f56f3e8 into bootstrap-vue:dev Feb 28, 2018

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 60.64%)
Details
codecov/project 60.78% (+0.13%) compared to 048c3d4
Details
deploy/netlify Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment