Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(breadcrumb-item): Fix `to` prop handling (Closes #2575) #2578

Merged

Conversation

Projects
None yet
2 participants
@jackmu95
Copy link
Member

commented Feb 15, 2019

Description of Pull Request:

This PR fixes an bug that prevented the to prop to actually work for <breadcrumb-item>.

Closes #2575

PR checklist:

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement to an existing feature
  • ARIA accessibility
  • Documentation update
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact:

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e.
    fixes #xxxx[,#xxxx], where "xxxx" is the issue number)
  • The PR should address only one issue or feature. If adding multiple features or fixing a bug
    and adding a new feature, break them into separate PRs if at all possible.
  • PR titles should following the
    Conventional Commits naming convention (i.e.
    "fix(alert): not alerting during SSR render", "docs(badge): Updated pill examples, fix typos",
    "chore: fix typo in docs", etc). This is very important, as the CHANGELOG is generated
    from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and
    event changes)
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (does it affect screen reader users or
    keyboard only users? clickable items should be in the tab index, etc)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a
    suggestion issue first and wait for approval before working on it)
@codecov

This comment has been minimized.

Copy link

commented Feb 15, 2019

Codecov Report

Merging #2578 into dev will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #2578      +/-   ##
==========================================
- Coverage   70.67%   70.65%   -0.02%     
==========================================
  Files         172      172              
  Lines        3168     3166       -2     
  Branches      919      919              
==========================================
- Hits         2239     2237       -2     
  Misses        676      676              
  Partials      253      253
Impacted Files Coverage Δ
src/components/breadcrumb/breadcrumb-link.js 100% <ø> (ø) ⬆️
src/components/breadcrumb/breadcrumb-item.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87a721f...968b394. Read the comment docs.

@jackmu95

This comment has been minimized.

Copy link
Member Author

commented Feb 15, 2019

@tmorehouse I've also looked through all other components that use <b-link> internally and this was the only one left overriding the href prop default values which caused the issues here.

jackmu95 added some commits Feb 15, 2019

@tmorehouse tmorehouse merged commit fba9df3 into bootstrap-vue:dev Feb 15, 2019

7 of 8 checks passed

codecov/project 70.65% (-0.02%) compared to 87a721f
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 87a721f...968b394
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (pi0) No manifest changes detected

@jackmu95 jackmu95 deleted the jackmu95:fix-breadcrumb-item-link-to-prop branch Feb 15, 2019

@tmorehouse tmorehouse referenced this pull request Feb 17, 2019

Merged

chore: release v2.0.0-rc.13 #2616

2 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.