-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pagination): correct pagination props/slots/event docs and fix ellipsis slot #2699
Merged
tmorehouse
merged 11 commits into
bootstrap-vue:dev
from
jacobmllr95:fix-docs-pagination
Feb 24, 2019
Merged
fix(pagination): correct pagination props/slots/event docs and fix ellipsis slot #2699
tmorehouse
merged 11 commits into
bootstrap-vue:dev
from
jacobmllr95:fix-docs-pagination
Feb 24, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #2699 +/- ##
====================================
Coverage 74% 74%
====================================
Files 173 173
Lines 3201 3201
Branches 939 939
====================================
Hits 2369 2369
Misses 610 610
Partials 222 222
Continue to review full report at Codecov.
|
tmorehouse
approved these changes
Feb 24, 2019
tmorehouse
changed the title
fix(docs): correct pagination props/slots/event docs
fix(pagination): correct pagination props/slots/event docs and fix ellipsis slot
Feb 24, 2019
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Pull Request:
This PR corrects the
<b-pagination>
docs about props, slots and events.Ref: #2655.
PR checklist:
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact:
The PR fulfills these requirements:
dev
branch, not themaster
branchfixes #xxxx[,#xxxx]
, where "xxxx" is the issue number)and adding a new feature, break them into separate PRs if at all possible.
Conventional Commits naming convention (i.e.
"fix(alert): not alerting during SSR render", "docs(badge): Updated pill examples, fix typos",
"chore: fix typo in docs", etc). This is very important, as the
CHANGELOG
is generatedfrom these messages.
If new features/enhancement/fixes are added or changed:
package.json
for slot andevent changes)
keyboard only users? clickable items should be in the tab index, etc)
If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:
suggestion issue first and wait for approval before working on it)