Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pagination): correct pagination props/slots/event docs and fix ellipsis slot #2699

Merged
merged 11 commits into from
Feb 24, 2019

Conversation

jacobmllr95
Copy link
Member

Description of Pull Request:

This PR corrects the <b-pagination> docs about props, slots and events.

Ref: #2655.

PR checklist:

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement to an existing feature
  • ARIA accessibility
  • Documentation update
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact:

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e.
    fixes #xxxx[,#xxxx], where "xxxx" is the issue number)
  • The PR should address only one issue or feature. If adding multiple features or fixing a bug
    and adding a new feature, break them into separate PRs if at all possible.
  • PR titles should following the
    Conventional Commits naming convention (i.e.
    "fix(alert): not alerting during SSR render", "docs(badge): Updated pill examples, fix typos",
    "chore: fix typo in docs", etc). This is very important, as the CHANGELOG is generated
    from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and
    event changes)
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (does it affect screen reader users or
    keyboard only users? clickable items should be in the tab index, etc)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a
    suggestion issue first and wait for approval before working on it)

@codecov
Copy link

codecov bot commented Feb 23, 2019

Codecov Report

Merging #2699 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff          @@
##            dev   #2699   +/-   ##
====================================
  Coverage    74%     74%           
====================================
  Files       173     173           
  Lines      3201    3201           
  Branches    939     939           
====================================
  Hits       2369    2369           
  Misses      610     610           
  Partials    222     222
Impacted Files Coverage Δ
src/mixins/pagination.js 68.58% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2708c74...92e42e5. Read the comment docs.

@tmorehouse tmorehouse changed the title fix(docs): correct pagination props/slots/event docs fix(pagination): correct pagination props/slots/event docs and fix ellipsis slot Feb 24, 2019
@tmorehouse tmorehouse merged commit 25e04e1 into bootstrap-vue:dev Feb 24, 2019
@tmorehouse tmorehouse mentioned this pull request Feb 24, 2019
4 tasks
@jacobmllr95 jacobmllr95 deleted the fix-docs-pagination branch February 24, 2019 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants