Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(carousel): disable the next/prev controls when the carousel is sliding (closes #4210) #4212

Merged
merged 3 commits into from Oct 7, 2019

Conversation

@tmorehouse
Copy link
Member

commented Oct 7, 2019

Describe the PR

Disable the previous / next controls when the slide is transitioning, to better align with Bootstrap v4's implementation.

Closes #4210

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe) user interface

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, fix typos, chore: fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)
…iding (closes #4210)
@codecov

This comment has been minimized.

Copy link

commented Oct 7, 2019

Codecov Report

Merging #4212 into dev will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #4212      +/-   ##
==========================================
- Coverage   99.86%   99.86%   -0.01%     
==========================================
  Files         237      237              
  Lines        4527     4525       -2     
  Branches     1274     1274              
==========================================
- Hits         4521     4519       -2     
  Misses          5        5              
  Partials        1        1
Impacted Files Coverage Δ
src/components/carousel/carousel.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e4f160...ace7b1d. Read the comment docs.

tmorehouse added 2 commits Oct 7, 2019
@tmorehouse tmorehouse marked this pull request as ready for review Oct 7, 2019
@tmorehouse tmorehouse requested a review from jackmu95 Oct 7, 2019
@tmorehouse tmorehouse merged commit 64d556d into dev Oct 7, 2019
8 checks passed
8 checks passed
License Compliance All checks passed.
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 99.86%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +0.13% compared to 7e4f160
Details
deploy/netlify Deploy preview ready!
Details
@tmorehouse tmorehouse deleted the issue/4210 branch Oct 7, 2019
@tmorehouse tmorehouse referenced this pull request Oct 8, 2019
6 of 6 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.