Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(b-toast): fix ensureToaster method call when toaster name changes #4468

Merged
merged 2 commits into from Dec 7, 2019

Conversation

SebastianSpeitel
Copy link
Contributor

@SebastianSpeitel SebastianSpeitel commented Dec 7, 2019

Describe the PR

The method call was missing it's parenthesis.

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, chore(docs): fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • CodeCov for patch has met target
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

src/components/toast/toast.js Outdated Show resolved Hide resolved
@tmorehouse tmorehouse changed the title fix: added missing parenthesis to call method fix(b-toast): add missing parenthesis to call method when toaster name changes Dec 7, 2019
@tmorehouse tmorehouse added PR: Patch Type: Fix labels Dec 7, 2019
@tmorehouse tmorehouse added this to In progress in 2.2.0 via automation Dec 7, 2019
@tmorehouse tmorehouse changed the title fix(b-toast): add missing parenthesis to call method when toaster name changes fix(b-toast): fix ensureToaster method call when toaster name changes Dec 7, 2019
@tmorehouse tmorehouse merged commit 744bb7a into bootstrap-vue:dev Dec 7, 2019
5 checks passed
2.2.0 automation moved this from In progress to Done Dec 7, 2019
@tmorehouse
Copy link
Member

@tmorehouse tmorehouse commented Dec 7, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Patch Type: Fix
Projects
No open projects
2.2.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants