Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(b-navbar-toggle): make default slot scoped #4995

merged 16 commits into from Mar 24, 2020

feat(b-navbar-toggle): make default slot scoped #4995

merged 16 commits into from Mar 24, 2020


Copy link

tmorehouse commented Mar 24, 2020

Describe the PR

Makes the default slot of <b-navbar-toggle> scoped, with the scope containing the collapse's expanded state.

Also documents that the component has a default slot

Plus minor code refactor for reduced bundle size

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe) minor code refactor for reduced bundle size

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, chore(docs): fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • CodeCov for patch has met target
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)
@tmorehouse tmorehouse added this to In progress in 2.9.0 via automation Mar 24, 2020

This comment has been minimized.

Copy link

codecov bot commented Mar 24, 2020

Codecov Report

Merging #4995 into dev will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #4995      +/-   ##
- Coverage   99.93%   99.93%   -0.01%     
  Files         273      273              
  Lines        6408     6403       -5     
  Branches     1617     1617              
- Hits         6404     6399       -5     
  Misses          3        3              
  Partials        1        1
Impacted Files Coverage Δ
src/components/collapse/collapse.js 100% <ø> (ø) ⬆️
src/directives/toggle/toggle.js 100% <100%> (ø) ⬆️
src/components/navbar/navbar-toggle.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8104b9...4c8f7c7. Read the comment docs.

tmorehouse added 4 commits Mar 24, 2020
@tmorehouse tmorehouse requested a review from jackmu95 Mar 24, 2020
@tmorehouse tmorehouse removed the Status: WIP label Mar 24, 2020
@tmorehouse tmorehouse marked this pull request as ready for review Mar 24, 2020
tmorehouse and others added 9 commits Mar 24, 2020
jackmu95 added 2 commits Mar 24, 2020
@tmorehouse tmorehouse merged commit 144d45f into dev Mar 24, 2020
9 checks passed
9 checks passed
License Compliance All checks passed.
ci/circleci: build Your tests passed on CircleCI!
ci/circleci: lint Your tests passed on CircleCI!
ci/circleci: setup Your tests passed on CircleCI!
ci/circleci: test Your tests passed on CircleCI!
codecov/patch 100% of diff hit (target 99.93%)
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +0.06% compared to e8104b9
netlify/bootstrap-vue/deploy-preview Deploy preview ready!
security/snyk (pi0) No manifest changes detected
2.9.0 automation moved this from In progress to Done Mar 24, 2020
@tmorehouse tmorehouse deleted the nav-toggle-scope branch Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.